Unify wording of resolve error #145399
Open
Unify wording of resolve error #145399
+605
−477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
This PR modifies |
This comment has been minimized.
This comment has been minimized.
estebank
force-pushed
the
resolve-error-wording-2
branch
from
fd49d2a to
298dec7
Compare
estebank
commented
Aug 14, 2025
| @@ -1,4 +1,4 @@ | |||
| error[E0433]: failed to resolve: partially resolved path in a macro | |||
| error[E0433]: cannot find `bar` in `Foo` | |||
| --> $DIR/extern-macro.rs:5:13 | |||
| | | |||
| LL | let _ = Foo::bar!(); | |||
There was a problem hiding this comment.
This is a diagnostic that needs improvement regardless: we need to explain that Foo is a type and that macros can't be in them. It would be particularly bad if Foo had an associated item bar as well.
There was a problem hiding this comment.
Changed the output to be
error[E0433]: cannot find macro `bar` in enum `Foo`
--> $DIR/extern-macro.rs:5:13
|
LL | let _ = Foo::bar!();
| ^^^^^^^^ a macro can't exist within an enum
Not perfect, but I feel it's more informative than we used to be.
estebank
commented
Aug 14, 2025
| @@ -41,7 +41,7 @@ LL - bar: st::cell::Cell<bool> | |||
| LL + bar: cell::Cell<bool> | |||
| | | |||
|
|
|||
| error[E0433]: failed to resolve: function `bar` is not a crate or module | |||
| error[E0433]: cannot find `bar` in this scope | |||
There was a problem hiding this comment.
Ah, I found I'd opened a separate PR already with some of these changes, and you had a comment about this change in particular
I agree that this isn't an improvement, but the primary label does still mention the intended issue. I'll see over the weekend what I can do about this.
estebank
added
the
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
petrochenkov
removed
the
S-waiting-on-review
Remove "failed to resolve" and use the same format we use in other resolution errors "cannot find `name`". ``` error[E0433]: cannot find `nonexistent` in `existent` --> $DIR/custom_attr_multisegment_error.rs:5:13 | LL | #[existent::nonexistent] | ^^^^^^^^^^^ could not find `nonexistent` in `existent` ```
estebank
force-pushed
the
resolve-error-wording-2
branch
from
298dec7 to
0b0bd12
Compare
estebank
force-pushed
the
resolve-error-wording-2
branch
from
0b0bd12 to
f6ce33d
Compare
estebank
commented
Aug 15, 2025
Comment on lines
+1
to
+5
| error[E0433]: cannot find derive macro `Anything` in trait `Foo` | ||
| --> $DIR/issue-46101.rs:2:10 | ||
| | | ||
| LL | #[derive(Foo::Anything)] | ||
| | ^^^^^^^^^^^^^ partially resolved path in a derive macro | ||
| | ^^^^^^^^^^^^^ a derive macro can't exist within a trait |
There was a problem hiding this comment.
Let me know if there's a wording you'd prefer for the label. I want to communicate the impossibility of the macro being in ADTs and traits in the first place.
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove "failed to resolve" from the main error message and use the same format we use in other resolution errors "cannot find
name":The intent behind this is to end up with all resolve errors eventually be on the form of
A category of errors that is interest are those that involve keywords. For example:
and
For these the label provides the actual help, while the message is less informative beyond telling you "couldn't find
name".This is an off-shoot of #126810 and #128086, a subset of the intended changes there with review comments applied.
r? @petrochenkov